Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data field for custom renderers #3059

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

github-maxime-liege
Copy link
Contributor

According to the proposal for the SDK Rendering API protocol

This PR adds a new field data to renderers object as discussed in the related thread

I switched to a more complex data type raw object instead of string to allow passing more datas into it.
Then all data related to the renderer SDK could be passed through this field.

Here is an example of how it could go:

{
  "name": "myRenderer",
  "version": "2.4",
  "data": {
    "uiRendereringVersion": "1.2",
    "resizable": true
  }
}

@github-maxime-liege github-maxime-liege force-pushed the add_data_field_custom_renderers branch from abba3b4 to 83db0ba Compare August 31, 2023 08:29
@SyntaxNode SyntaxNode self-requested a review August 31, 2023 12:20
@SyntaxNode SyntaxNode self-assigned this Aug 31, 2023
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants